Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Tauri #66

Merged
merged 5 commits into from
Mar 17, 2024
Merged

Clean up Tauri #66

merged 5 commits into from
Mar 17, 2024

Conversation

dscso
Copy link
Contributor

@dscso dscso commented Mar 16, 2024

The following changes:

  • path_trav had to be removed
    • path traversal is prevented by not allowing certain characters in the filename
    • path_trav uses fs::canonicalize internally, which always fails if a file does not exist => not suited for our needs
  • tauri notification replaced with mac-notification-sys
  • file download supports progress
    • a callback can be registered when starting the download (see below)
  • set badge count is supported by setBadgeCount(count: number)
    • app needs to be packaged for this to work
  • this.__isApp = !this.__isBrowser was replaced with this.__isApp = window.__TAURI__ !== undefined
    • the old version was not working
await UtilitiesRuntime.requestFileDownload(
  event.file.url,
  event.file.name,
  (current, total) => console.log(`${Math.round(current/total*100)}% done`)
);

@dscso
Copy link
Contributor Author

dscso commented Mar 17, 2024

a57ed39 adds support for deep linking. If the application is compiled and placed in the /Applications folder, Prose registers as a opener for xmpp:// URLs

@dscso dscso changed the title clean up tauri side, download progress, notifications changed to mac-… Clean up Tauri Mar 17, 2024
@dscso dscso merged commit aac7db9 into master Mar 17, 2024
0 of 2 checks passed
@dscso dscso mentioned this pull request Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant